feat: upgrade @objectstack dependencies to v2.0.0#356
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Update all @objectstack/spec, @objectstack/core, @objectstack/runtime, @objectstack/objectql, @objectstack/cli, @objectstack/plugin-hono-server versions across 21 package.json files - Add required `sortable` field to FieldConfig objects in core/src/util.ts (new required property in @objectstack/spec v2.0.0) Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
|
There was a problem hiding this comment.
Pull request overview
Upgrades the monorepo’s external @objectstack/* dependencies from v1.1.0 to v2.0.0 and adapts the codebase to the v2 breaking change that makes FieldConfig.sortable required (starting with the DB introspection output).
Changes:
- Bump
@objectstack/*dependency versions across workspacepackage.jsonfiles and updatepnpm-lock.yamlaccordingly. - Update
convertIntrospectedSchemaToObjectsto includesortable: falsein generatedFieldConfigobjects (lookup + regular fields).
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile update reflecting @objectstack v2.0.0 upgrades (and associated transitive changes). |
| package.json | Root dependency bumps for @objectstack/cli, @objectstack/core, and @objectstack/plugin-hono-server. |
| packages/protocols/odata-v4/package.json | Upgrade @objectstack/spec/@objectstack/core to v2.0.0. |
| packages/protocols/json-rpc/package.json | Upgrade @objectstack/spec/@objectstack/core to v2.0.0. |
| packages/protocols/graphql/package.json | Upgrade @objectstack/spec/@objectstack/core to v2.0.0. |
| packages/foundation/types/package.json | Upgrade @objectstack/spec devDependency to v2.0.0. |
| packages/foundation/plugin-workflow/package.json | Upgrade @objectstack/core/@objectstack/spec to v2.0.0. |
| packages/foundation/plugin-validator/package.json | Upgrade @objectstack/core/@objectstack/spec to v2.0.0. |
| packages/foundation/plugin-security/package.json | Upgrade @objectstack/core/@objectstack/spec to v2.0.0. |
| packages/foundation/plugin-multitenancy/package.json | Upgrade @objectstack/core/@objectstack/spec to v2.0.0. |
| packages/foundation/plugin-formula/package.json | Upgrade @objectstack/core/@objectstack/spec to v2.0.0. |
| packages/foundation/platform-node/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/foundation/core/package.json | Upgrade @objectstack/core/@objectstack/objectql/@objectstack/runtime/@objectstack/spec to v2.0.0. |
| packages/foundation/core/src/util.ts | Add required sortable field to generated FieldConfig in introspection conversion paths. |
| packages/drivers/sqlite-wasm/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/drivers/sql/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/drivers/sdk/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/drivers/redis/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/drivers/pg-wasm/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/drivers/mongo/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/drivers/memory/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/drivers/fs/package.json | Upgrade @objectstack/spec to v2.0.0. |
| packages/drivers/excel/package.json | Upgrade @objectstack/spec to v2.0.0. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| reference_to: foreignKey.referencedTable, | ||
| label: toTitleCase(column.name), | ||
| required: !column.nullable, | ||
| searchable: false | ||
| searchable: false, | ||
| sortable: false |
There was a problem hiding this comment.
sortable was added here for introspection, but upgrading @objectstack/spec to v2 makes FieldConfig.sortable required everywhere a FieldConfig literal is constructed. There are multiple existing const fieldConfig: FieldConfig = { ... } usages (e.g. in packages/foundation/plugin-validator/test/*.ts) that currently omit sortable, which will break TypeScript compilation and/or spec validation. Please update those FieldConfig literals (or, if the intention is to rely on defaults, adjust the FieldConfig typing/parsing layer so sortable can be omitted safely).
Upgrades all
@objectstack/*packages from v1.1.0 to v2.0.0 across the monorepo and adapts code to breaking changes.Dependency bumps
@objectstack/spec,@objectstack/core,@objectstack/runtime,@objectstack/objectql,@objectstack/cli,@objectstack/plugin-hono-server→ 2.0.0 in 21package.jsonfilesBreaking change:
FieldConfig.sortablenow required@objectstack/specv2.0.0 addssortableas a required field onFieldConfig. Fixed inpackages/foundation/core/src/util.ts:Both the lookup field path and the regular field path in
introspectDatabasewere updated.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.